Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix accessibility issue with video editor speed option selected speed #36310

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

saadyousafarbi
Copy link
Contributor

@saadyousafarbi saadyousafarbi commented Feb 27, 2025

TNL-11863

Description

Accessibility fix for video component in speed option

We have changed the color of the text to #90D7F9 and achieved a 4:54:1 contrast ratio.

Sandbox Link

Testing Sandbox video block

Before

unnamed3 (1)

After

Screenshot 2025-02-27 at 4 44 39 PM Screenshot 2025-02-27 at 4 46 19 PM

@saadyousafarbi saadyousafarbi marked this pull request as ready for review February 27, 2025 11:57
@saadyousafarbi saadyousafarbi requested a review from a team February 27, 2025 11:57
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saadyousafarbi saadyousafarbi merged commit 790fdcf into master Mar 3, 2025
49 checks passed
@saadyousafarbi saadyousafarbi deleted the saad/TNL-11863 branch March 3, 2025 08:21
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants